Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for exclude-should-panic #82348

Open
1 task
ehuss opened this issue Feb 20, 2021 · 1 comment
Open
1 task

Tracking Issue for exclude-should-panic #82348

ehuss opened this issue Feb 20, 2021 · 1 comment
Labels
A-libtest Area: `#[test]` / the `test` library C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ehuss
Copy link
Contributor

ehuss commented Feb 20, 2021

This is a tracking issue for the --exclude-should-panic flag of libtest.

This prevents tests annotated with the should_panic attribute from running.

Implementation: #58689

Unresolved Questions

  • Is this useful for anyone? It was added for miri, but as of update README miri#1104, it appears miri no longer needs it.
@ehuss ehuss added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC labels Feb 20, 2021
@Mark-Simulacrum
Copy link
Member

We had wanted this in #55861 (comment), but ultimately those tests were also disabled. IIRC, I also ran into the problem that usually using this in a non-internal way (e.g., for miri) you also want it for rustdoc.

@ehuss ehuss added the A-libtest Area: `#[test]` / the `test` library label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-libtest Area: `#[test]` / the `test` library C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
testing-devex backlog
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ehuss @Mark-Simulacrum