-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Don't override system keyboard shortcuts for search results tab-switcher #79872
Comments
Not a fan of overriding system shortcuts, but I do think this is less pressing than the tab issue. Wondering what suggestions people have. |
Wouldn't replace |
I believe cmd-up/down is also a system shortcut? If it's not that would work. |
To be checked then! I'll try to do that this evening or tomorrow. |
Command–Up Arrow and Command–Down Arrow are used for scrolling to the top and bottom of the page in many browsers, including Safari and Firefox (and I assume Google Chrome). I don't think we should override that if we're looking to be as accessible as possible. Unfortunately, many of the keyboard shortcut options are already taken :/ |
Arf. :-/ |
What about using keys without modifiers? E.g. |
I'd personnally prefer that those events are only handled when we have the focus on the search input. |
I think using letter keys for navigation when you're in a search view but outside the search box makes sense. |
That could work. I don't know how many of our users have their own letter keys bound to something, not sure if that would be a problem? |
It's very rare. |
Once #79862 is merged, rustdoc will be overriding the macOS system keyboard
shortcuts Ctrl-↑ and Ctrl-↓ (Control–Up Arrow and Control–Down Arrow).
Personally, I don't use these shortcuts, but I imagine others do. We should find
different key combinations that won't override system shortcuts.
See the discussion around #79862 (comment).
cc @GuillaumeGomez @Manishearth
The text was updated successfully, but these errors were encountered: