Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Internal type implementations of From trait leak on std doc #75873

Closed
tesuji opened this issue Aug 24, 2020 · 4 comments
Closed

rustdoc: Internal type implementations of From trait leak on std doc #75873

tesuji opened this issue Aug 24, 2020 · 4 comments
Labels
C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@tesuji
Copy link
Contributor

tesuji commented Aug 24, 2020

The "Implementations on Foreign Types" sections doesn't appear in stable and beta doc, which is good:
https://doc.rust-lang.org/nightly/std/convert/trait.From.html#foreign-impls
image

Meta

rustc --version --verbose: Version 1.47.0-nightly (5180f3d 2020-08-23)

@rustbot modify labels: T-rustdoc T-compiler
@tesuji tesuji added the C-bug Category: This is a bug. label Aug 24, 2020
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 24, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Aug 24, 2020

cc @Mark-Simulacrum this might be related to gimli PR.

@Mark-Simulacrum
Copy link
Member

Yeah, it almost certainly is. I thought we had fixed this, but I guess not quite. I'll take a look, but I'm not too worried about this personally.

@jyn514
Copy link
Member

jyn514 commented Aug 24, 2020

Possible duplicate of #74672

@tesuji
Copy link
Contributor Author

tesuji commented Aug 24, 2020

Duplicate of #74672 .

@tesuji tesuji closed this as completed Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Mark-Simulacrum @tesuji @jyn514 @rustbot