Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions "tools" builder is broken #71184

Closed
RalfJung opened this issue Apr 16, 2020 · 8 comments
Closed

GitHub Actions "tools" builder is broken #71184

RalfJung opened this issue Apr 16, 2020 · 8 comments
Labels
A-github-actions Area: GitHub Actions (GHA) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Apr 16, 2020

In #71173, the Azure "tools" PR builder succeeded, but the GHA "tools" builder failed twice because it considers rls and rustfmt broken, saying

error[E0464]: multiple matching crates for `getopts`
 --> /cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_session-651.0.0/lib.rs:6:1
  |
6 | extern crate getopts;
  | ^^^^^^^^^^^^^^^^^^^^^
  |
  = note: candidates:
          crate `getopts`: /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgetopts-c1029da41ced9898.rlib
          crate `getopts`: /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgetopts-0ef7d7c079c561c3.rlib

error[E0463]: can't find crate for `getopts`
 --> /cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_session-651.0.0/lib.rs:6:1
  |
6 | extern crate getopts;
  | ^^^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to 2 previous errors

Looks to me like something is wrong with the GHA builder.

Cc @pietroalbini

@jonas-schievink jonas-schievink added A-github-actions Area: GitHub Actions (GHA) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 16, 2020
@Mark-Simulacrum
Copy link
Member

This is almost certainly not spurious - rustfmt likely needs to update it's version of the autopublished rustc_session crate. I can take a look today at doing so.

@RalfJung
Copy link
Member Author

Well, it works fine on the Azure runners though (and the PR landed now).

@RalfJung
Copy link
Member Author

But also #71159 landed in the mean time... but when the Azure runner ran I don't think it had landed already.

@pietroalbini
Copy link
Member

I'm pretty sure that's because GHA is using a fork of the toolstate repository in my own account, and updating the data is still broken. Let's see if it turns green once I update my fork.

@Mark-Simulacrum
Copy link
Member

Ah, yeah, that could explain it. Both the Azure and GHA builds failed the exact same way, just GHA considered that a regression (so it failed, as we're in beta week).

@pietroalbini
Copy link
Member

Updated the fork, let's see if it works now.

@pietroalbini
Copy link
Member

Opened #71195 to track master failing.

@pietroalbini
Copy link
Member

After the updated fork this started working again, closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-github-actions Area: GitHub Actions (GHA) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants