Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is feature compiler_builtins_lib still needed for libstd? #66368

Closed
dingelish opened this issue Nov 13, 2019 · 2 comments · Fixed by #66538
Closed

Is feature compiler_builtins_lib still needed for libstd? #66368

dingelish opened this issue Nov 13, 2019 · 2 comments · Fixed by #66538
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@dingelish
Copy link
Contributor

rust/src/libstd/lib.rs

Line 247 in 374ad1b

#![feature(compiler_builtins_lib)]

After compiler-builtins issue 322 and PR 324, do we still need this line? Compilation succeeded after this line is moved on linux-x86_64.
@dingelish
Copy link
Contributor Author

Issue 322
rust-lang/compiler-builtins#322

PR324
rust-lang/compiler-builtins#324

@jonas-schievink jonas-schievink added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Nov 13, 2019
@Centril Centril added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Nov 13, 2019
@dingelish
Copy link
Contributor Author

dingelish commented Nov 18, 2019 •
edited
Loading

Hi there, could I create an PR to run the CI so that we could check if we can remove this line? Thanks!

@dingelish dingelish reopened this Nov 18, 2019
@dingelish dingelish mentioned this issue Nov 19, 2019
Merged
@bors bors closed this as completed in e1a32fa Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove compiler_builtins_lib feature from libstd
3 participants
@Centril @jonas-schievink @dingelish