Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#65076 #65084

Closed
rust-highfive opened this issue Oct 4, 2019 · 7 comments · Fixed by #65328
Closed

rls no longer builds after rust-lang/rust#65076 #65084

rust-highfive opened this issue Oct 4, 2019 · 7 comments · Fixed by #65328
Assignees
@Xanewok
Labels
P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #65076, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @tmandry, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @tmandry, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 4, 2019
@tmandry
Copy link
Member

tmandry commented Oct 5, 2019

rustfmt was broken by #64690 so I'd start with looking at that.

@topecongiro
Copy link
Contributor

@Xanewok I have just released rustfmt 1.4.9. racer has been fixed as well (cc racer-rust/racer#1076), but the fix is not published yet.

@topecongiro topecongiro mentioned this issue Oct 10, 2019
Closed
@pnkfelix
Copy link
Member

visiting for triage: P-high, removing nomination label.

@pnkfelix pnkfelix added P-high High priority and removed I-nominated labels Oct 10, 2019
@ghedo ghedo mentioned this issue Oct 10, 2019
Merged
@kngwyu
Copy link
Contributor

kngwyu commented Oct 11, 2019

@Xanewok
I also released racer 2.1.28.
It's ready to update RLS.

@Xanewok
Copy link
Member

Xanewok commented Oct 11, 2019

Great, thanks! I’ll update this today.

@ghedo ghedo mentioned this issue Oct 11, 2019
Merged
@ghedo
Copy link
Contributor

ghedo commented Oct 11, 2019

@Xanewok ah, missed your comment, so I created rust-lang/rls#1563 just now. Hope that's ok.

@Xanewok
Copy link
Member

Xanewok commented Oct 11, 2019

The RLS dep bump has landed, so now we need to open a PR with an update to both RLS and Rustfmt.

@Xanewok Xanewok mentioned this issue Oct 11, 2019
Closed
@tesuji tesuji mentioned this issue Oct 12, 2019
Merged
@bors bors closed this as completed in 1721c96 Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

Labels
P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update rls and rustfmt tesuji/rustc
Update RLS and Rustfmt Xanewok/rust
7 participants
@ghedo @pnkfelix @tmandry @Xanewok @rust-highfive @kngwyu @topecongiro