Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remap-debuginfo causes some rustc tests to fail #63339

Closed
ehuss opened this issue Aug 6, 2019 · 1 comment
Closed

remap-debuginfo causes some rustc tests to fail #63339

ehuss opened this issue Aug 6, 2019 · 1 comment
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@ehuss
Copy link
Contributor

ehuss commented Aug 6, 2019

Setting remap-debuginfo to true in config.toml will cause a few tests to fail. They are:

  • ui/impl-trait/impl-generic-mismatch.rs
  • ui/consts/const-size_of-cycle.rs
  • ui/type_length_limit.rs

The issue is that these tests use $SRC_DIR in their .stderr output, but when the standard library is built with --remap-path-prefix, these paths will not be shown at all in the output.

I can't think of an easy way to work around that. My only idea is to add an "ignore" flag to compiletest so that these tests can be ignored when remapping is enabled.
@Centril Centril added A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2019
@jonas-schievink jonas-schievink added the C-bug Category: This is a bug. label Aug 7, 2019
@ehuss
Copy link
Contributor Author

ehuss commented Aug 11, 2020

I believe this is now resolved, probably via #70642 (or one of its related PRs).

@ehuss ehuss closed this as completed Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ehuss @Centril @jonas-schievink