-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hashbrown's trait implementations appear in std docs #62763
Comments
hashbrown
's trait implementations appear in std docs
I only saw hashbrown in examples. If so, it can be fixed easily. Or did I miss something? |
I just realised that it's not linking to std types apparently, which is weird... Also, I think we should "hide" the hashbrown types if possible since I *think* they're public for the moment. |
The You could |
That's what I meant when I wrote "I just realised that it's not linking to std types apparently, which is weird..." (badly said though). What's difficult is that we have types depending on std types which depend on those types. Circular documentation, I think that's a first haha! |
We should probably apply |
As far as I can tell, the only usages of |
I think this was fixed by #76571 - @17cupsofcoffee can you double check? |
Yes, the issue seems to be fixed - the only |
Perhaps this is a known issue, but I've noticed that since
hashbrown
was integrated into the standard library, impls from that crate now show up under the 'Implementations on Foreign Types' section of the trait docs.This is unfortunate, since the
hashbrown
versions of those types aren't actually accessible throughstd
(std::collections::HashMap
andstd::collections::HashSet
are effectively newtypes wrapping them). Adding to the confusion, these seem to get precedence naming-wise over the actual implementations that you can use, which are referred to by their fully qualified names further down the page.I'm not sure if anything can actually be done about this without changes to rustdoc, and it's not a huge deal, but I figured it was worth raising :)
The text was updated successfully, but these errors were encountered: