Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: Move most of the bash scripts out of the Azure yamls into separate files #61169

Closed
pietroalbini opened this issue May 25, 2019 · 2 comments
Labels
T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@pietroalbini
Copy link
Member

Consider putting any bash script longer than a few lines in a standalone script that can be invoked instead of inlined into yml, perhaps under a /scripts folder.

This allows you to easily run & lint the script, whereas it takes extra steps to do so in yaml.

Originally posted by @zachChilders in #60777

@pietroalbini pietroalbini added azure-evaluation T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 25, 2019
@alexcrichton
Copy link
Member

I would personally say that we shouldn't necessarily strive to remove all >1 line scripts from the *.yml files. I think there's a lot to benefit from having it all centralized in one location, especially if there's different scripts for different platforms. If all our CI platforms share the same script I think it's ok to extract, but once Windows does one thing and Unix does another thing I personally find it more clear to follow scripts inline than to have to chase down a bunch of files to make sure everything is synchronized.

@alexcrichton alexcrichton changed the title Move most of the bash scripts out of the Azure yamls into separate files azure: Move most of the bash scripts out of the Azure yamls into separate files May 25, 2019
@pietroalbini
Copy link
Member Author

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants