Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression in nightly #56274

Closed
valff opened this issue Nov 27, 2018 · 3 comments
Closed

Performance regression in nightly #56274

valff opened this issue Nov 27, 2018 · 3 comments
Labels
I-compiletime Issue: Problems and improvements with respect to compile times. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@valff
Copy link
Contributor

valff commented Nov 27, 2018

nightly-2018-11-26 introduced 10x compile time slow-down compared to nightly-2018-11-25. Here is a minimal working example: https://github.com/valff/rustc-perf-regression
@nikic
Copy link
Contributor

nikic commented Nov 27, 2018 •
edited
Loading

Perf top has the majority of the time spent in _ZN5rustc5infer9InferCtxt20create_next_universe17hea623e9d2897e73eE, so this is very likely due to #55921, which is already being fixed at #56251.

@valff
Copy link
Contributor Author

valff commented Nov 27, 2018

That's great. I will test with the next nightly tomorrow and close the issue if it's fixed.

@Centril Centril added the I-compiletime Issue: Problems and improvements with respect to compile times. label Nov 27, 2018
@nagisa nagisa added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 27, 2018
@valff
Copy link
Contributor Author

valff commented Nov 28, 2018

I confirm that version 400c2bc5e 2018-11-27 fixes this. It is even 5% better than before! Very nice, thank you.

@valff valff closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-compiletime Issue: Problems and improvements with respect to compile times. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nikic @nagisa @Centril @valff