Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Notable Traits" for &[u8] includes Write, which is only on &mut [u8] #55082

Closed
scottmcm opened this issue Oct 15, 2018 · 2 comments · Fixed by #108954
Closed

"Notable Traits" for &[u8] includes Write, which is only on &mut [u8] #55082

scottmcm opened this issue Oct 15, 2018 · 2 comments · Fixed by #108954
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@scottmcm
Copy link
Member

https://doc.rust-lang.org/nightly/std/string/struct.String.html#method.as_bytes

The popup has

Important traits for &'a [u8]

impl<'a> Read for &'a [u8]
impl<'a> Write for &'a mut [u8]

Write seems like it shouldn't be in that list.
@Havvy Havvy added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 15, 2018
@GuillaumeGomez
Copy link
Member

cc @QuietMisdreavus

@ollie27 ollie27 mentioned this issue Jul 16, 2020
Merged
@scottmcm
Copy link
Member Author

Triage: still repros on the current nightly.

@scottmcm scottmcm mentioned this issue Sep 12, 2020
Closed
@jyn514 jyn514 added the C-bug Category: This is a bug. label Dec 15, 2020
@jsha jsha mentioned this issue Aug 9, 2022
Closed
@jsha jsha changed the title "Important Traits" for &[u8] includes Write, which is only on &mut[u8] "Notable Traits" for &[u8] includes Write, which is only on &mut [u8] Aug 9, 2022
@notriddle notriddle mentioned this issue Mar 9, 2023
Merged
@bors bors closed this as completed in 0392e29 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: handle generics better when matching notable traits notriddle/rust
4 participants
@Havvy @GuillaumeGomez @scottmcm @jyn514