Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler error message shows the error path containing parent directory identifier ( /../ ) #51349

Open
fbernier opened this issue Jun 4, 2018 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@fbernier
Copy link
Contributor

fbernier commented Jun 4, 2018

error[E0599]: no method named `map` found for type `std::iter::Map<postgres::rows::Iter<'_>, for<'r, 's> fn(postgres::rows::Row<'r>, &'s extract::CmdOptions) -> std::result::Result<<Q as extract::query::Query>::Message, postgres::Error> {<Q as extract::query::Query>::map}>` in the current scope
  --> extract/tests/query/../helper.rs:40:10
   |
40 |         .map(Result::unwrap)

the actual error is in extract/tests/helper.rs and that's what I would expect to be displayed instead of extract/tests/query/../helper.rs.

binary: rustc
commit-hash: 827013a31b88e536e85b8e6ceb5b9988042ec335
commit-date: 2018-05-25
host: x86_64-unknown-linux-gnu
release: 1.26.1
LLVM version: 6.0
@estebank estebank added the A-diagnostics Area: Messages for errors, warnings, and lints label Jun 4, 2018
@estebank
Copy link
Contributor

estebank commented Jun 6, 2018

Path::canonicalize could be used for <FileName as Display>, which would get rid of the /../ (which you can't just do with the text of the path because of symlinks), but we should probably do so only in non-windows environments, as canonicalize uses UNC paths on windows.

@hdhoang hdhoang added C-enhancement Category: An issue proposing an enhancement or a PR with one. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Nov 7, 2019
@crlf0710 crlf0710 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 11, 2020
@basavesh
Copy link
Contributor

Can I work on this?

@estebank
Copy link
Contributor

@basavesh of course! Looking at the closed PR should give you a good idea of what needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants