Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parallel-queries] Refactor error message handling to better integrate with parallel queries #49737

Open
michaelwoerister opened this issue Apr 6, 2018 · 2 comments
Open

[parallel-queries] Refactor error message handling to better integrate with parallel queries #49737

michaelwoerister opened this issue Apr 6, 2018 · 2 comments
Labels
A-parallel-queries Area: Parallel query execution C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@michaelwoerister
Copy link
Member

At the moment error message handling uses a callback-based setup in order to handle diagnostics tracking during query evaluation. This could probably be handled in a cleaner way.

Also, the current system has no way of making error message output somewhat deterministic under parallel execution.

Both problems should be solved by re-factoring the system to better fit the changed needs.
@michaelwoerister michaelwoerister added the A-parallel-queries Area: Parallel query execution label Apr 6, 2018
@nikomatsakis nikomatsakis mentioned this issue Apr 6, 2018
Open
31 tasks
@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2018
@sasurau4
Copy link
Contributor

It seems that this issue solved with #67614.

@michaelwoerister
Copy link
Member Author

I don't think that PR takes care of emitting error messages in a deterministic order, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parallel-queries Area: Parallel query execution C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaelwoerister @XAMPPRocky @sasurau4