Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a lint check for unused pure function return values #4507

Closed
thestinger opened this issue Jan 16, 2013 · 3 comments
Closed

add a lint check for unused pure function return values #4507

thestinger opened this issue Jan 16, 2013 · 3 comments
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one.
Milestone

Comments

@thestinger
Copy link
Contributor

If the definition of pure is changed to allow mutating arguments, functions with &mut arguments could just be ignored by this check. Alternatively, if there ends up being something like mut pure as a lighter form of purity, those ones would be skipped.

@catamorphism
Copy link
Contributor

+1

@pcwalton
Copy link
Contributor

I think this should extend to all function return values, actually, except those for C functions or those notated by #[ignorable_return_value] (or something like that).

@graydon
Copy link
Contributor

graydon commented Mar 13, 2013

pure functions are going away, so closing this as WONTFIX (#2974 is the general case)

@graydon graydon closed this as completed Mar 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

4 participants