Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slate beta regression #43960

Closed
est31 opened this issue Aug 17, 2017 · 2 comments
Closed

slate beta regression #43960

est31 opened this issue Aug 17, 2017 · 2 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta.

Comments

@est31
Copy link
Member

est31 commented Aug 17, 2017

slate version 1.3.0 test-regressed from stable to beta (full log):

Aug 16 21:51:06.438 INFO blam! ---- config::tests::it_uses_the_homedir_as_default_path stdout ----
Aug 16 21:51:06.439 INFO blam! 	thread 'config::tests::it_uses_the_homedir_as_default_path' panicked at 'assertion failed: `(left == right)`
Aug 16 21:51:06.439 INFO blam!   left: `"/home/cargobomb/.slate"`,
Aug 16 21:51:06.439 INFO blam!  right: `"/tmp/slate"`', src/config.rs:87:8
Aug 16 21:51:06.439 INFO blam! note: Run with `RUST_BACKTRACE=1` for a backtrace.

cc @jhbabon
@bstrie bstrie added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Aug 18, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Aug 20, 2017
@alexcrichton
Copy link
Member

Racy test, global state with environment variables.

@est31 est31 mentioned this issue Aug 20, 2017
Closed
@jhbabon
Copy link

jhbabon commented Aug 21, 2017

Yes, sorry about that. I'll try to fix the test so it doesn't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexcrichton @jhbabon @bstrie @Mark-Simulacrum @est31