Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timely-0.1.5 beta regression #43664

Closed
est31 opened this issue Aug 5, 2017 · 1 comment
Closed

timely-0.1.5 beta regression #43664

est31 opened this issue Aug 5, 2017 · 1 comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Aug 5, 2017

timely version 0.1.5 regressed from stable to beta. Cargobomb couldn't pick it up directly as root regression and reported it on other crates. Error excerpt:

    Compiling timely v0.1.15
 error: no rules expected the token `EventStreamLogger<OperatesEvent, File>`
    --> /cargo-home/registry/src/github.com-1ecc6299db9ec823/timely-0.1.15/src/logging.rs:160:35
     |
 160 |               __thread_local_inner!($t, $init);
     |                                     ^^
 ...
 164 | / thread_local!{
 165 | |     /// Logs operator creation.
 166 | |     pub static OPERATES: EventStreamLogger<OperatesEvent, File> = EventStreamLogger::new();
 167 | |     /// Logs channel creation.
 ...   |
 178 | |     pub static GUARDED_PROGRESS: EventStreamLogger<bool, File> = EventStreamLogger::new();
 179 | | }
     | |_- in this macro invocation
 
 error: Could not compile `timely`.

Affects crates:

cc @frankmcsherry

@arielb1 arielb1 added regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2017
@arielb1
Copy link
Contributor

arielb1 commented Aug 5, 2017

Duplicate of #43681.

@arielb1 arielb1 closed this as completed Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants