DefPathData should use InternedString, not Name #35292
Labels
A-incr-comp
Area: Incremental compilation
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
Currently
DefPathData
embeds aName
. The intention was to have an interned string and ignore hygiene. But it turns out thatName
still has a kind of quasi-hygiene -- usinggensym
, you can create two names with the same string representation but distinct identifiers. We should be usingInternedString
inDefPathData
instead, I believe. Otherwise you can wind up with two def-ids with def-paths that, after serialization, appear exactly the same (since we serialize theName
by writing out the string value, but that is not sufficient to capture thisgensym
quality).This shows up e.g. in the
iter
variable created by thefor
lowering.The text was updated successfully, but these errors were encountered: