Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-C soft-float silently ignored on x86 #31798

Closed
MagaTailor opened this issue Feb 20, 2016 · 8 comments
Closed

-C soft-float silently ignored on x86 #31798

MagaTailor opened this issue Feb 20, 2016 · 8 comments

Comments

@MagaTailor
Copy link

On 32-bit x86 compiling with -C soft-float produces a binary but judging from the generated assembly this option is silently ignored.

Even if it's silly to expect this to work in absence of library support, shouldn't a warning be printed at least?

@GuillaumeGomez
Copy link
Member

I think it might be a good idea to prevent users in case this option cannot be run. Want to do it @petevine?

@MagaTailor
Copy link
Author

Provided it's not too difficult I probably wouldn't want to tread on your patch anyway ;)
What exactly were you suggesting?

@GuillaumeGomez
Copy link
Member

I didn't start, that's why I asked you before doing anything.

@MagaTailor
Copy link
Author

I know, it was a pun. Are we talking about a warning or an error?

@GuillaumeGomez
Copy link
Member

My bad! :p

Since it's unavoidable, displaying an error which says something like "this option is not available on this computer" just before leaving seems fine to me.

Do you confirm @Manishearth?

@Manishearth
Copy link
Member

I suggest we add a warning, not error. Often such flags are passed down by the build system with a "make it work if possible" intention, so we shouldn't crash.

@nagisa
Copy link
Member

nagisa commented Feb 22, 2016

It is a bug we ignore the option and we should fix that instead. Software float emulation is possible regardless of target, but might need some extra libraries (e.g. libsoft-fp) being linked in.

@MagaTailor
Copy link
Author

#36261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants