Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Private structs implementing public traits are visible as dangling links #19106

Closed
nodakai opened this issue Nov 19, 2014 · 2 comments
Closed

rustdoc: Private structs implementing public traits are visible as dangling links #19106

nodakai opened this issue Nov 19, 2014 · 2 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@nodakai
Copy link
Contributor

nodakai commented Nov 19, 2014

Seeing is believing: http://doc.rust-lang.org/std/ops/trait.Drop.html

core::finally::Finallyalizer and collections::vec::PartialVecNonZeroSized are two of many dangling links in the Drop page. They shouldn't be visible at all because core::finally and PartialVecNonZeroSized are private items.
@scialex scialex mentioned this issue Nov 19, 2014
Closed
@scialex
Copy link
Contributor

scialex commented Nov 19, 2014

I think this is because --passes strip-priv is totally broken. See #19111

@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 29, 2015
@alexcrichton
Copy link
Member

Closing as a duplicate of #14586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @alexcrichton @nodakai @scialex