Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest: -Cincremental in ui tests dump incr build output to source directories #128057

Open
jieyouxu opened this issue Jul 22, 2024 · 2 comments
Open

compiletest: -Cincremental in ui tests dump incr build output to source directories #128057

jieyouxu opened this issue Jul 22, 2024 · 2 comments
Assignees
@jieyouxu
Labels
A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Jul 22, 2024 •
edited
Loading

See #128038:

Currently tests can ICE when the test spits out inc-fat incremental artifacts directly into the top of the git checkout, and then the compiler version changes, and it reads nonsense incremental artifacts on a subsequent test run.

I think the right flag to add when porting -Cincremental run-make tests is to use //@ incremental rather than manually specifying the -Cincremental rustflag.

If manual -Cincremental specified in compile-flags cause output to the working directory (not even build directory), then we really should error and suggest //@ incremental.
@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-compiletest Area: The compiletest test runner labels Jul 22, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 22, 2024
@jieyouxu jieyouxu moved this from Backlog to In progress in compiletest maintenance and improvements Jul 22, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 22, 2024
@jieyouxu jieyouxu self-assigned this Jul 22, 2024
@compiler-errors
Copy link
Member

compiler-errors commented Jul 22, 2024 •
edited
Loading

Either that, or we can set the working directory of the rustc invokation to be in built/$TARGET/test/test_name/. Perhaps that's the better option? IDK what that messes up tho.

@jieyouxu
Copy link
Member Author

Either that, or we can set the working directory of the rustc invokation to be in built/$TARGET/test/test_name/. Perhaps that's the better option? IDK what that messes up tho.

The safest option is probably to do both lol

@jieyouxu jieyouxu changed the title compiletest: error if -Cincremental is passed in compile-flags in ui tests compiletest: -Cincremental in ui tests dump incr build output to source directories Dec 2, 2024
@jieyouxu jieyouxu added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
compiletest maintenance and improvements
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@compiler-errors @jieyouxu @rustbot