Tracking Issue for Rust 2024: Make unsafe_op_in_unsafe_fn warn-by-default

[traviscross]

This is a tracking issue for making unsafe_op_in_unsafe_fn warn-by-default in Rust 2024 per:

• Make unsafe_op_in_unsafe_fn warn-by-default starting in 2024 edition #120535
• Tracking Issue for "unsafe blocks in unsafe fn" (RFC #2585) #71668 (comment)

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

• Implement in nightly Rust 2024.
  • Change unsafe_op_in_unsafe_fn to be warn-by-default from edition 2024 #112038
• Implement migration lints.
  • Make unsafe_op_in_unsafe_fn auto-migrated in 2024 edition #119823
  • Make unsafe_op_in_unsafe_fn migrated in edition 2024 #119948
• Add documentation to the dev guide.
  • See the instructions.
  • (Unneeded)
• Add documentation to the reference.
  • See the instructions.
  • (The reference does not list lints; however, it is fully documented in the rustc book.)
• Add formatting for new syntax to the style guide.
  • See the nightly style procedure.
  • (Unneeded; there is no new syntax.)
• Add documentation to the edition guide.
  • (Done: https://github.com/rust-lang/edition-guide/blob/master/src/rust-2024/unsafe-op-in-unsafe-fn.md)
  • Add some more initial stub docs for 2024. edition-guide#291
• Ensure ready for Rust 2024 stabilization.

Unresolved Questions

None.

Related

• Tracking Issue for "unsafe blocks in unsafe fn" (RFC #2585) #71668
• Make unsafe_op_in_unsafe_fn warn-by-default starting in 2024 edition #120535

Implementation history

• Change unsafe_op_in_unsafe_fn to be warn-by-default from edition 2024 #112038
• Make unsafe_op_in_unsafe_fn auto-migrated in 2024 edition #119823
• fix(cargo-fix): dont apply same suggestion twice cargo#13728

cc @tmandry

[traviscross]

We discussed this in our edition call today, and this item looks entirely ready for Rust 2024.

Huge thanks to @tmandry for making that happen.

[ehuss]

Note: A crater run for this was done in #122960, and identified #13728 as an issue, which is fixed via a change in cargo. Otherwise it went well. 🎉

[tmandry]

Woohoo, the first edition change of 2024 is ready!

A big thanks to @Nemo157, @asquared31415, and @weihanglo for contributing the implementation and bug fixes. And thanks for @RalfJung for the RFC.