Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./x.py test does not explain why a #[should_panic] test failed #111825

Closed
Xiretza opened this issue May 21, 2023 · 1 comment · Fixed by #111826
Closed

./x.py test does not explain why a #[should_panic] test failed #111825

Xiretza opened this issue May 21, 2023 · 1 comment · Fixed by #111826
Assignees
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Xiretza
Copy link
Contributor

Xiretza commented May 21, 2023

When an stdlib #[should_panic] test does not actually panic, ./x.py test fails but gives no explanation as to why, even with -vv:

$ ./x.py test library/core/ -vv
[snip]
     Running `$HOME/dev/rust/rustc/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/coretests-207451fa6fb9ecc4 --quiet -Z unstable-options --format json`

running 1596 tests
........................................................................................   88/1596
........................................................................................  176/1596
........................................................................................  264/1596
........................................................................................  352/1596
........................................................................................  440/1596
........................................................................................  528/1596
........................................................................................  616/1596
.....................................................ii.................................  704/1596
........................................................................................  792/1596
........................................................................................  880/1596
........................................................................................  968/1596
........................................................................................ 1056/1596
........................................................................................ 1144/1596
........................................................................................ 1232/1596
........................................................................................ 1320/1596
................................................................FFFF.................... 1408/1596
........................................................................................ 1496/1596
........................................................................................ 1584/1596
............

failures:


failures:
    slice::slice_rsplit_array_ref_out_of_bounds
    slice::slice_rsplit_array_mut_out_of_bounds
    slice::slice_split_array_mut_out_of_bounds
    slice::slice_split_array_ref_out_of_bounds

test result: FAILED. 1590 passed; 4 failed; 2 ignored; 0 measured; 0 filtered out; finished in 1.28s

error: test failed, to rerun pass `-p core --test coretests`

The instructions at the end also don't work, ./x.py test doesn't have -p or --test parameters.

@ehuss
Copy link
Contributor

ehuss commented May 21, 2023

Looks like this was a small oversight from #108659. I have posted a fix for this.

@jyn514 jyn514 added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels May 21, 2023
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 21, 2023
@jyn514 jyn514 removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 21, 2023
@bors bors closed this as completed in e2362d7 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants