Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing generic_associated_types stabilisation version? #101766

Closed
matthiaskrgr opened this issue Sep 13, 2022 · 6 comments · Fixed by #101772
Closed

missing generic_associated_types stabilisation version? #101766

matthiaskrgr opened this issue Sep 13, 2022 · 6 comments · Fixed by #101772
Labels
C-bug Category: This is a bug.

Comments

@matthiaskrgr
Copy link
Member

#![feature(generic_associated_types)]
pub fn main() {}

with rustc master rustc 1.65.0-nightly (5338f5f1d 2022-09-13)

warning: the feature `generic_associated_types` has been stable since CURRENT_RUSTC_VERSION and no longer requires an attribute to enable
 --> f.rs:1:12
  |
1 | #![feature(generic_associated_types)]
  |            ^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(stable_features)]` on by default

warning: 1 warning emitted

looks like the stabilisation version is borked? 😅
cc @jackh726

@matthiaskrgr matthiaskrgr added the C-bug Category: This is a bug. label Sep 13, 2022
@matthiaskrgr
Copy link
Member Author

@jackh726
Copy link
Member

This is correct, but not ideal: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#updating-the-feature-gate-listing

cc @est31 maybe we want to special case this in the diagnostics

@est31
Copy link
Member

est31 commented Sep 13, 2022

Yeah seems I've missed correcting that lint. For GATs, the stabilization version will be adjusted very soon, in the coming days, as we are close to the release cycle. But this needs to be fixed for future stabilizations as well. Working on a PR. @rustbot label bug

@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2022

Error: Label bug can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@est31
Copy link
Member

est31 commented Sep 13, 2022

Yeah it warns correctly for lib features so only lang features are affected:

warning: the feature `io_read_to_string` has been stable since 1.65.0-nightly and no longer requires an attribute to enable
 --> src/main.rs:1:12
  |
1 | #![feature(io_read_to_string)]
  |            ^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(stable_features)]` on by default

@est31
Copy link
Member

est31 commented Sep 13, 2022

PR filed: #101772

@bors bors closed this as completed in 94bc08d Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants