Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc-Json: Large Amount of unreferenced core in index #101201

Closed
aDotInTheVoid opened this issue Aug 30, 2022 · 2 comments
Closed

Rustdoc-Json: Large Amount of unreferenced core in index #101201

aDotInTheVoid opened this issue Aug 30, 2022 · 2 comments
Labels
A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@aDotInTheVoid
Copy link
Member

aDotInTheVoid commented Aug 30, 2022

#![no_std]
pub fn foo() {}

Has an enormous output, that includes core::fmt::Write, and many other unreferenced items.

Many of these items also have dangling Id's.

Possibly caused by #101105

@rustbot modify labels: +A-rustdoc-json +T-rustdoc

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 30, 2022
@aDotInTheVoid
Copy link
Member Author

Turn out the actual culprit is adding extra trait impls:

index.extend(self.get_trait_items());

Removing this fixes all tests for jsondoclint, and fails none of the current tests, but I thinks thats more of an inditement of the test suite than anything else.

@aDotInTheVoid
Copy link
Member Author

Fixed by #128385 (CC @its-the-shrimp).

The output index now only contains 2 items, the module and the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants