From daf916bf9a0a785497741e14a68ae57fd578db1b Mon Sep 17 00:00:00 2001 From: Jeffrey Seyfried Date: Thu, 2 Jun 2016 07:34:19 +0000 Subject: [PATCH 1/2] Fix bug in the `syntax::config::StripUnconfigured` folder --- src/libsyntax/config.rs | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/libsyntax/config.rs b/src/libsyntax/config.rs index 14035d8d116a3..c164e89c52f38 100644 --- a/src/libsyntax/config.rs +++ b/src/libsyntax/config.rs @@ -166,14 +166,6 @@ impl fold::Folder for T { }; let item = match item { - ast::ItemKind::Impl(u, o, a, b, c, items) => { - let items = items.into_iter().filter_map(|item| self.configure(item)).collect(); - ast::ItemKind::Impl(u, o, a, b, c, items) - } - ast::ItemKind::Trait(u, a, b, items) => { - let items = items.into_iter().filter_map(|item| self.configure(item)).collect(); - ast::ItemKind::Trait(u, a, b, items) - } ast::ItemKind::Struct(def, generics) => { ast::ItemKind::Struct(fold_struct(self, def), generics) } @@ -242,7 +234,17 @@ impl fold::Folder for T { } fn fold_item(&mut self, item: P) -> SmallVector> { - self.configure(item).map(|item| SmallVector::one(item.map(|i| self.fold_item_simple(i)))) + self.configure(item).map(|item| fold::noop_fold_item(item, self)) + .unwrap_or(SmallVector::zero()) + } + + fn fold_impl_item(&mut self, item: ast::ImplItem) -> SmallVector { + self.configure(item).map(|item| fold::noop_fold_impl_item(item, self)) + .unwrap_or(SmallVector::zero()) + } + + fn fold_trait_item(&mut self, item: ast::TraitItem) -> SmallVector { + self.configure(item).map(|item| fold::noop_fold_trait_item(item, self)) .unwrap_or(SmallVector::zero()) } } From 9639ec87e7c64548b6a7cb800562ec1cf1094c04 Mon Sep 17 00:00:00 2001 From: Jeffrey Seyfried Date: Thu, 2 Jun 2016 07:43:44 +0000 Subject: [PATCH 2/2] Add regression test --- src/test/compile-fail/issue-34028.rs | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 src/test/compile-fail/issue-34028.rs diff --git a/src/test/compile-fail/issue-34028.rs b/src/test/compile-fail/issue-34028.rs new file mode 100644 index 0000000000000..117ab18a1158a --- /dev/null +++ b/src/test/compile-fail/issue-34028.rs @@ -0,0 +1,21 @@ +// Copyright 2016 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![feature(rustc_attrs)] + +macro_rules! m { + () => { #[cfg(any())] fn f() {} } +} + +trait T {} +impl T for () { m!(); } + +#[rustc_error] +fn main() {} //~ ERROR compilation successful