Never stop due to errors before borrow checking

Author: estebank

src/librustc_interface/passes.rs

@@ -936,13 +936,6 @@ fn analysis<'tcx>(
         });
     });
 
-    // Abort so we don't try to construct MIR with liveness errors.
-    // We also won't want to continue with errors from rvalue promotion
-    // We only do so if the only error found so far *isn't* a missing `fn main()`
-    if !(entry_point.is_none() && sess.err_count() == 1) {
-        tcx.sess.abort_if_errors();
-    }
-
     time(sess, "borrow checking", || {
         if tcx.use_ast_borrowck() {
             borrowck::check_crate(tcx);

src/test/ui/consts/const_let_refutable.rs

@@ -1,5 +1,5 @@
 fn main() {}
 
 const fn slice([a, b]: &[i32]) -> i32 { //~ ERROR refutable pattern in function argument
-    a + b
+    a + b //~ ERROR can only call other `min_const_fn` within a `min_const_fn`
 }

src/test/ui/consts/const_let_refutable.stderr

@@ -4,6 +4,15 @@ error[E0005]: refutable pattern in function argument: `&[]` not covered
 LL | const fn slice([a, b]: &[i32]) -> i32 {
    |                ^^^^^^ pattern `&[]` not covered
 
-error: aborting due to previous error
+error[E0723]: can only call other `min_const_fn` within a `min_const_fn` (see issue #57563)
+  --> $DIR/const_let_refutable.rs:4:5
+   |
+LL |     a + b
+   |     ^^^^^
+   |
+   = help: add #![feature(const_fn)] to the crate attributes to enable
+
+error: aborting due to 2 previous errors
 
-For more information about this error, try `rustc --explain E0005`.
+Some errors occurred: E0005, E0723.
+For more information about an error, try `rustc --explain E0005`.

src/test/ui/error-codes/E0007.rs

@@ -4,6 +4,7 @@ fn main() {
         op_string @ Some(s) => {},
         //~^ ERROR E0007
         //~| ERROR E0303
+        //~| ERROR E0382
         None => {},
     }
 }

src/test/ui/error-codes/E0007.stderr

@@ -10,7 +10,18 @@ error[E0303]: pattern bindings are not allowed after an `@`
 LL |         op_string @ Some(s) => {},
    |                          ^ not allowed after `@`
 
-error: aborting due to 2 previous errors
+error[E0382]: use of partially moved value: `x`
+  --> $DIR/E0007.rs:4:9
+   |
+LL |         op_string @ Some(s) => {},
+   |         ^^^^^^^^^^^^^^^^^-^
+   |         |                |
+   |         |                value moved here
+   |         value used here after move
+   |
+   = note: move occurs because the value has type `std::string::String`, which does not implement the `Copy` trait
+
+error: aborting due to 3 previous errors
 
-Some errors occurred: E0007, E0303.
+Some errors occurred: E0007, E0303, E0382.
 For more information about an error, try `rustc --explain E0007`.

src/test/ui/error-codes/E0030-teach.rs

@@ -4,5 +4,6 @@ fn main() {
     match 5u32 {
         1000 ..= 5 => {}
         //~^ ERROR lower range bound must be less than or equal to upper
+        //~| ERROR lower range bound must be less than or equal to upper
     }
 }

src/test/ui/error-codes/E0030-teach.stderr

@@ -6,6 +6,12 @@ LL |         1000 ..= 5 => {}
    |
    = note: When matching against a range, the compiler verifies that the range is non-empty. Range patterns include both end-points, so this is equivalent to requiring the start of the range to be less than or equal to the end of the range.
 
-error: aborting due to previous error
+error[E0030]: lower range bound must be less than or equal to upper
+  --> $DIR/E0030-teach.rs:5:9
+   |
+LL |         1000 ..= 5 => {}
+   |         ^^^^ lower bound larger than upper bound
+
+error: aborting due to 2 previous errors
 
 For more information about this error, try `rustc --explain E0030`.

src/test/ui/error-codes/E0301.rs

@@ -2,6 +2,6 @@ fn main() {
     match Some(()) {
         None => { },
         option if option.take().is_none() => {}, //~ ERROR E0301
-        Some(_) => { }
+        Some(_) => { } //~^ ERROR E0596
     }
 }

src/test/ui/error-codes/E0301.stderr

@@ -4,6 +4,15 @@ error[E0301]: cannot mutably borrow in a pattern guard
 LL |         option if option.take().is_none() => {},
    |                   ^^^^^^ borrowed mutably in pattern guard
 
-error: aborting due to previous error
+error[E0596]: cannot borrow immutable local variable `option` as mutable
+  --> $DIR/E0301.rs:4:19
+   |
+LL |         option if option.take().is_none() => {},
+   |         ------    ^^^^^^ cannot borrow mutably
+   |         |
+   |         help: make this binding mutable: `mut option`
+
+error: aborting due to 2 previous errors
 
-For more information about this error, try `rustc --explain E0301`.
+Some errors occurred: E0301, E0596.
+For more information about an error, try `rustc --explain E0301`.

src/test/ui/error-codes/E0302.rs

@@ -2,6 +2,6 @@ fn main() {
     match Some(()) {
         None => { },
         option if { option = None; false } => { }, //~ ERROR E0302
-        Some(_) => { }
+        Some(_) => { }  //~^ ERROR E0384
     }
 }