Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command/key binding to accept replacements #478

Open
andrejohansson opened this issue Dec 23, 2021 · 5 comments
Open

Add command/key binding to accept replacements #478

andrejohansson opened this issue Dec 23, 2021 · 5 comments
Labels
A-suggestions Area: diagnostic suggestions

Comments

@andrejohansson
Copy link

Thank you for an excellent plugin.

I was just wondering if there is any key binding or command to accept the clippy replacements in the phantom popups?
image

Or any keybindings to navigate the popups at all?
image

Sorry if I'm asking in the wrong place, it´s kind of unclear to me which parts belong to this plugin, lsp or sublime native! :-)

@ehuss
Copy link

ehuss commented Dec 24, 2021

There is not a keybinding for accepting suggestions. That does sound like a good idea, though!

The second picture looks to come from Sublime LSP which is a separate package. I'm not very familiar with it, so I'm not sure what it is capable of.

@LollipopFt
Copy link

hi @andrejohansson , sorry if i disturbed you but what settings did you use to have the yellow, blue and green backgrounds in the first image for rust enhanced?

@andrejohansson
Copy link
Author

No problem:
https://rust-lang.github.io/rust-enhanced/build/messages.html#phantom-themes

I think I just set solid here!

@LollipopFt
Copy link

@andrejohansson thanks!

@ehuss ehuss added the A-suggestions Area: diagnostic suggestions label Jun 11, 2022
@ehuss ehuss changed the title Question: Key binding for clippy actions? Add command/key binding to accept replacements Jun 11, 2022
@eugenesvk
Copy link

eugenesvk commented May 20, 2024

That'd be a very nice feature indeed! Thought is there a Sublime API to track which popup is active? As far as I understand, you only get to register a function that reacts to clicks/close events

Though there is a command to go to the next/previous suggestion, maybe hat could be of help ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-suggestions Area: diagnostic suggestions
Projects
None yet
Development

No branches or pull requests

4 participants