Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-D warnings should deny warnings from lint renames #8485

Closed
daprilik opened this issue Mar 1, 2022 · 3 comments
Closed

-D warnings should deny warnings from lint renames #8485

daprilik opened this issue Mar 1, 2022 · 3 comments

Comments

@daprilik
Copy link

daprilik commented Mar 1, 2022

Description

e.g: setting -W clippy::disallowed_type -D warnings when invoking clippy currently results in the following warning:

warning: lint `clippy::disallowed_type` has been renamed to `clippy::disallowed_types`
  |
  = note: requested on the command line with `-W clippy::disallowed_type`

...when this should be a hard error (due to the -D warnings)

Version

rustc 1.59.0 (9d1b2106e 2022-02-23)
binary: rustc
commit-hash: 9d1b2106e23b1abd32fce1f17267604a5102f57a
commit-date: 2022-02-23
host: x86_64-pc-windows-msvc
release: 1.59.0
LLVM version: 13.0.0

Additional Labels

No response

@xFrednet
Copy link
Member

xFrednet commented Mar 1, 2022

This is an interesting bug, thank you for the report. The message actually comes from rustc. Would you mind filing this in the rust repo? 🙃

@daprilik
Copy link
Author

daprilik commented Mar 1, 2022

@xFrednet done 👍

@xFrednet
Copy link
Member

xFrednet commented Mar 1, 2022

Thank you, very much! I'll close this in favor of the other rust one 🙃

@xFrednet xFrednet closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants