Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: Inline Suggestions #9544

Closed
Tracked by #86
kjeremy opened this issue Jul 9, 2021 · 5 comments
Closed
Tracked by #86

vscode: Inline Suggestions #9544

kjeremy opened this issue Jul 9, 2021 · 5 comments
Labels
A-completion autocompletion A-lsp LSP conformance issues and missing features A-vscode vscode plugin issues

Comments

@kjeremy
Copy link
Contributor

kjeremy commented Jul 9, 2021

vscode 1.58.0 has a proposed api for "Inline Suggestions". It would be cool if we could use this (once finalized) with our completion for preferred items.

@jonas-schievink
Copy link
Contributor

@yume-chan
Copy link

Inline suggestion is mainly for multiline suggestions (which doesn't fit the suggestion widget).

With "editor.suggest.preview": true, suggestion preview automatically works for tranditional suggestion providers including TypeScript and JSON (other languages not tested).

image

But strangely, it doesn't work with rust-analyzer

image

@Veykril Veykril added A-lsp LSP conformance issues and missing features A-completion autocompletion A-vscode vscode plugin issues labels May 28, 2022
@HKalbasi
Copy link
Member

"editor.suggest.preview": true now works for me in vscode 1.73, even for multi line suggestions (like adding a function inside an impl Trait). Anything else remaining on this, or it can be closed?

@Veykril
Copy link
Member

Veykril commented Nov 20, 2022

VSCode has a specific API for this, though I am not sure what the benefits of it are https://code.visualstudio.com/api/references/vscode-api#InlineCompletionItemProvider

@HKalbasi
Copy link
Member

IIUC the difference is that inline suggestion doesn't show the traditional suggestion dialog (which we probably don't want) and it has different ui for switching and selecting, for example it uses Alt + [ instead of arrow keys for switching between suggestions. I think it is intended to use when the suggestion dialog doesn't make sense (like for copilot suggestions)

@Veykril Veykril closed this as completed Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-completion autocompletion A-lsp LSP conformance issues and missing features A-vscode vscode plugin issues
Projects
None yet
Development

No branches or pull requests

5 participants