Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing symbols does not see aliases #7938

Closed
Tracked by #14079
JDuchniewicz opened this issue Mar 9, 2021 · 4 comments · Fixed by #15477
Closed
Tracked by #14079

Listing symbols does not see aliases #7938

JDuchniewicz opened this issue Mar 9, 2021 · 4 comments · Fixed by #15477
Assignees
Labels
A-nameres name, path and module resolution C-bug Category: bug S-unactionable Issue requires feedback, design decisions or is blocked on other work

Comments

@JDuchniewicz
Copy link

Issue from coc-rust-analyzer

The problem is best illustrated as such:

We have a struct Vec3; and a use Vec3 as Color statement.
When running CocList -I symbols and searching for Vec3 it finds it just fine but does not resolve Color.

This is apparently a limitation of aliases and has been discussed in libs zullip recently. Relevant issue in the language?

@jonas-schievink
Copy link
Contributor

That's not a type alias, just a renamed import. What LSP API does CocList -I symbols use? workspace/symbol?

@JDuchniewicz
Copy link
Author

Unfortunately, I am not able to find it with the codebase, maybe @fannheyward could help?

@jonas-schievink
Copy link
Contributor

If it does use workspace/symbol, I believe this is working as intended. Type aliases should show up in there, but renamed imports shouldn't.

@fannheyward
Copy link
Contributor

Yes, coc uses workspace/symbol, tested with VSCode + rust-analyzer, same results.

@flodiebold flodiebold added the S-unactionable Issue requires feedback, design decisions or is blocked on other work label Mar 14, 2021
@Veykril Veykril added the A-nameres name, path and module resolution label Feb 2, 2023
@Veykril Veykril added the C-bug Category: bug label Feb 3, 2023
@Veykril Veykril self-assigned this Aug 17, 2023
@bors bors closed this as completed in d895e9e Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-nameres name, path and module resolution C-bug Category: bug S-unactionable Issue requires feedback, design decisions or is blocked on other work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants