Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ra_syntax fails to compile with rustc 1.31.0-nightly (96064eb 2018-10-28) #185

Closed
kjeremy opened this issue Nov 1, 2018 · 2 comments
Closed

Comments

@kjeremy
Copy link
Contributor

kjeremy commented Nov 1, 2018

See rust-lang/rust#55475

@alanhdu
Copy link
Contributor

alanhdu commented Nov 5, 2018

Not sure how much this helps, but the following diff makes this ICE go away.

diff --git a/crates/ra_syntax/src/grammar/expressions/mod.rs b/crates/ra_syntax/src/grammar/expressions/mod.rs
index 60c8602..38dc518 100644
--- a/crates/ra_syntax/src/grammar/expressions/mod.rs
+++ b/crates/ra_syntax/src/grammar/expressions/mod.rs
@@ -1,7 +1,7 @@
 mod atom;
 
 pub(crate) use self::atom::match_arm_list;
-pub(super) use self::atom::{literal, LITERAL_FIRST};
+pub(super) use self::atom::LITERAL_FIRST;
 use super::*;
 
 const EXPR_FIRST: TokenSet = LHS_FIRST;
diff --git a/crates/ra_syntax/src/grammar/patterns.rs b/crates/ra_syntax/src/grammar/patterns.rs
index 10fa0e0..3f61886 100644
--- a/crates/ra_syntax/src/grammar/patterns.rs
+++ b/crates/ra_syntax/src/grammar/patterns.rs
@@ -49,9 +49,6 @@ fn atom_pat(p: &mut Parser, recovery_set: TokenSet) -> Option<CompletedMarker> {
     //         "hello" => (),
     //     }
     // }
-    if let Some(m) = expressions::literal(p) {
-        return Some(m);
-    }
 
     let m = match la0 {
         UNDERSCORE => placeholder_pat(p),

@DJMcNab
Copy link
Contributor

DJMcNab commented Dec 9, 2018

I think this was fixed by rust-lang/rust#56143. It builds on 1.31 on stable anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants