Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update rust-analyzer in rust-lang/rust #15776

Closed
gigaroby opened this issue Oct 17, 2023 · 8 comments
Closed

Please update rust-analyzer in rust-lang/rust #15776

gigaroby opened this issue Oct 17, 2023 · 8 comments
Labels
C-feature Category: feature request

Comments

@gigaroby
Copy link
Contributor

Hi,
we (at Google) are building the rust toolchain (rust-lang/rust) and its components in a custom way (https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds?branch=master). I am currently trying to get rust-analyzer to build but I ran into an issue with the ra-ap-... crates. It seems like a feature recently landed to allow us to build rust-analyzer fully in-tree (f4704bc) but this hasn't made its way into rust-lang/rust.

Would it be possible to sync the rust-analyzer version in rust-lang/rust to that in rust-lang/rust-analyzer? I'm happy to do this myself but I haven't figured out how this is done.

@gigaroby gigaroby added the C-feature Category: feature request label Oct 17, 2023
@lnicola
Copy link
Member

lnicola commented Oct 17, 2023

There's currently a problem related to publishing the ra-ap_ crates, but I'll have a fix tomorrow or so.

Regarding the sync, last time I tried it didn't work for some reasons we didn't understand. I'll try again soon.

@gigaroby
Copy link
Contributor Author

The ra-ap_ crates will not work for us regardless of any fixes due to how our build process is set up. Please let me know if I can help investigate why the sync process was failing.

@lnicola
Copy link
Member

lnicola commented Oct 17, 2023

Just filed rust-lang/rust#116847.

@gigaroby
Copy link
Contributor Author

Hi @lnicola, any updates to share? I am happy to help if there's anything I can do.

@lnicola
Copy link
Member

lnicola commented Nov 15, 2023

rust-lang/rust#117701 updated the subtree version to the Nov 6th release, on Monday I'll try to catch up.

@hlopko
Copy link

hlopko commented Nov 15, 2023

Fantastic, thank you for pushing this forward!

@lnicola
Copy link
Member

lnicola commented Nov 17, 2023

With rust-lang/rust#117985, the subtree is currently up-to-date. Thank you for your patience.

@lnicola lnicola closed this as completed Nov 17, 2023
@hlopko
Copy link

hlopko commented Nov 17, 2023

Thank you so much @lnicola!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature request
Projects
None yet
Development

No branches or pull requests

3 participants