Very limited autocomplete

[rsalmei]

Hi,

Please, why is the autocomplete so very limited like this? Is this correct? Is this intended??

I want to autocomplete Ipv6Addr, I push I (upper i):

Yep, there are only these 17 entries. I push p:

Now there isn't any... I push v:

Now it suddenly finds these two. It's very weird (and worrying, I must be missing A LOT of suggestions).
Why didn't these two entries come on the very first suggestions? They do contain upper I after all.
Why does Ip return nothing?
Is there some configuration I could change to get all the entries at once?

Thank you.

rust-analyzer version: rust-analyzer version: 0.3.1681-standalone (0840038 2023-09-30)
rustc version: rustc 1.72.0 (5680fa18f 2023-08-23)

[flodiebold]

Suggestions for names that aren't imported yet (that add a use statement) are only provided if there are at least three characters to match. Otherwise the completion list would get huge and slow.

[Veykril]

I wonder, we could maybe do mere prefix matching for importing completions with <3 characters? That should limit the completions pretty well and gives intuitive results I think?

[rsalmei]

Suggestions for names that aren't imported yet (that add a use statement) are only provided if there are at least three characters to match. Otherwise the completion list would get huge and slow.

Thanks, I see.
But I wonder if that list would really be that huge and slow... Jetbrains' Rust plugin does bring a huge list with a single upper I, and instantaneously, including the Ipv6Addr:

EDIT: Oh, and they do find within the words (not only prefix search), even with lowercase:

[Veykril]

Ideally we'd do the same, but it's just not currently feasible with how do things.

[rsalmei]

May I ask why? Because they use Kotlin+Java, and we use Rust after all...
Anyway, this PR of yours will surely improve things a lot!! Thank you very much.

[Veykril]

Different architecture, having to align with the LSP which mainly results in our completions currently just not being very efficient currently.

[rsalmei]

I see, it is not performant with the current architecture... Thanks, man.

[rsalmei]

Please @Veykril, when is this going to be released?
It didn't make both the changelogs 202 and 203 already.

EDIT: Never mind, it did make into the 203! (I've looked for the issue, it was the PR) 👍