Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GOTO def from *inside* files included with include! macro? #14937

Closed
cmyr opened this issue May 31, 2023 · 0 comments · Fixed by #16439
Closed

Support for GOTO def from *inside* files included with include! macro? #14937

cmyr opened this issue May 31, 2023 · 0 comments · Fixed by #16439
Labels
A-ide general IDE features C-feature Category: feature request

Comments

@cmyr
Copy link

cmyr commented May 31, 2023

so as of #14561, goto definition will now correctly locate tokens defined in a file that is included with the include! macro. This is wonderful.

Now there is the natural follow-up: would it be possible to have goto work within the generated file?

I can see some ways that this is complicated. In particular, there is potentially an N->1 relationship between include! invocations and their targets, which means that there could be different sets (of possibly overlapping) symbols in scope for a given included file. I would imagine that any possible implementation of this would need to be limited to the case where any single file is only included from a single other file.

So... I'm really not sure how feasible this is, but it seems at least like something that would be nice to have eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ide general IDE features C-feature Category: feature request
Projects
None yet
2 participants