Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do more name resolution in body lowering #14498

Open
Veykril opened this issue Apr 5, 2023 · 2 comments
Open

Do more name resolution in body lowering #14498

Veykril opened this issue Apr 5, 2023 · 2 comments
Labels
A-hir hir and hir-def related C-Architecture Big architectural things which we need to figure up-front (or suggestions for rewrites :0) ) C-enhancement Category: enhancement

Comments

@Veykril
Copy link
Member

Veykril commented Apr 5, 2023

Right now body lowering is just that, going from AST -> HIR, all resolution actually happens in type checking. This makes the inference query a lot more complicated than it needs to be. Some things we should probably resolve are labels, lifetimes (unsure about this one) and paths (only partially given paths might require type info for full resolution).

cc #14368 (comment)

@Veykril Veykril added A-hir hir and hir-def related C-enhancement Category: enhancement labels Apr 5, 2023
@Veykril Veykril added the Broken Window Bugs / technical debt to be addressed immediately label Sep 6, 2023
@Veykril
Copy link
Member Author

Veykril commented Sep 6, 2023

This is now getting more messy with our half backed addition of lang paths and #15559 adding an assoc path segment to that

@Veykril
Copy link
Member Author

Veykril commented Mar 16, 2024

Actually, we might want to lift his name resolution into another query. Body queries currently depend on the AstIdMap which gets invalidated on every change in a file causing us to recalculate all bodies. So making that query slower is not necessarily a good idea.

@Veykril Veykril added C-Architecture Big architectural things which we need to figure up-front (or suggestions for rewrites :0) ) and removed Broken Window Bugs / technical debt to be addressed immediately labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-hir hir and hir-def related C-Architecture Big architectural things which we need to figure up-front (or suggestions for rewrites :0) ) C-enhancement Category: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant