-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dev-tools peer groups to rfcbot #153
Comments
We wanted to use this for rust-lang/rust#43949, but can't yet. |
@steveklabnik you can add the team (T-dev-tools-docs) to the Rust repo and it should Just Work (I've been waiting to add teams as they are needed - I add dev-tools-docs to the RFCs repo already but not Rust). |
@nrc there needs to be a database entry for rfcbot to associate team members to a particular label. I can walk someone through the process of doing the database migration, and I'm also wanting to move the configuration for teams to a static file deployed with the bot. The latter might take a bit though. |
My memory here is that the requisite labels needed to be created on all of the various repositories before I went through and created the configuration. Has that been done? |
https://github.com/orgs/rust-lang/teams/t-dev-tools-docs <- I made this team a "child team" of dev-tools; dunno if that's the right thing or not. |
@dikaiosune we don't have a specific docs peers label; we use |
@steveklabnik That was the request; if we want to signal the rustdoc peers specifically, we would add a new label for it - using |
Going to try to do more work on rfcbot soon, but it'll be a kinda weird refactor to change the assumption "1 team/subteam of humans" <-> "1 github label." I'll think about how to do this well, but I think some of the other debt payoff may end up taking priority. |
I just deployed the new-ish rfcbot code. Fingers crossed nothing blows up! The team configuration is no longer pulled from the database, and is instead pulled from teams.toml. If you want to add a new "team" like the peers, PRs are very welcome! |
Looks like we added the rustdoc devtools peers at some point so I think this is resolved. |
internals.rust-lang.org announcement post (alongside the infra and cargo teams)
It looks like the core dev-tools team has been added, but for RFCs that primarily concern a specific tool, like RFC 1946 for Rustdoc, it may be necessary to add the peers for that tool to the FCP checklist. The individual peer groups are listed in the announcement post linked above. According to @aturon and @nrc, the plan is to have separate tags for each tool, like
T-dev-tools-rustdoc
on the aforementioned RFC, and to tag bothT-dev-tools
andT-dev-tools-foo
(for some tool "foo") to pull in the core dev-tools team and the peers for that specific tool.The text was updated successfully, but these errors were encountered: