Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Modify downloads.md to use the default template #247

Closed
brson opened this issue Jan 14, 2016 · 6 comments
Closed

Modify downloads.md to use the default template #247

brson opened this issue Jan 14, 2016 · 6 comments

Comments

@brson
Copy link
Contributor

brson commented Jan 14, 2016

After the next update most every page on the website has a consist style with a horizontal rule and page title following the header. Except the download page, which has a very customized style. It looks weird to me when I'm clicking between pages.

@fredericmarx
Copy link
Contributor

I built a possible fix for this at fredericmarx@7ca5d95.

Feel free to comment.

screen shot 2016-03-30 at 02 37 55

@brson
Copy link
Contributor Author

brson commented Jun 10, 2016

@fredericmarx Sorry I missed your comments here. The screenshot looks good to me, except that for some reason the "Downloads" header feels out of place to me. I'm not sure if it's just because I'm so used to the page without the header or not. It seems like doesn't fit into the page as well as the others, where on the other pages the header is immediately followed be some sort of summary text.

Perhaps I would get used to it. @steveklabnik what do you think of that screen?

@steveklabnik
Copy link
Member

I feel exactly the same. I'm tempted to merge it though, as I don't really dislike it, I'm just not sure if I like it, which is a subtle difference.

@fredericmarx
Copy link
Contributor

Ha, no worries, I also only just realised you had replied.

Any news on this? I figured as most pages had a header it would be a good idea to have one here, too, for consistency's sake. I don't have a strong opinion against leaving it out though either.

@steveklabnik
Copy link
Member

I think I vote merge. @brson ?

@brson
Copy link
Contributor Author

brson commented Jun 21, 2016

Yes let's do it @fredericmarx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants