New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOMException: button# is not a valid selector #1151

Closed

peaceshi opened this issue Feb 22, 2020 · 1 comment · Fixed by #1170

Labels

C-panic

peaceshi commented Feb 22, 2020

mdBook/src/theme/book.js

Line 287 in 4039c72

themePopup.querySelector("button#" + document.body.className).focus();

just need remove #.

steveklabnik added the C-panic label

Member

steveklabnik commented Mar 15, 2020

(Marking as T-panic because the dom threw an exception. not technically a panic but close enough!)

ehuss mentioned this issue

Fix theme selector focus. #1170

Merged

ehuss closed this as completed in #1170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment