Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP template should better reflect actual feedback latency #180

Closed
scottmcm opened this issue Feb 12, 2023 · 9 comments
Closed

ACP template should better reflect actual feedback latency #180

scottmcm opened this issue Feb 12, 2023 · 9 comments
Labels
documentation Improvements or additions to documentation

Comments

@scottmcm
Copy link
Member

The ACP template currently says

This issue is part of the libs-api team [API change proposal process]. Once this issue is filed the libs-api team will review open proposals in its weekly meeting. You should receive feedback within a week or two.

However, near as I can tell, ACPs are not reviewed in the weekly meetings -- at least there's no notes about them in minutes like https://hackmd.io/l8zlGD8cQqeYSfHKG3O33A.

And thus it seems like setting the expectation of "a week or two" for feedback is misleading. It's easy to find examples without feedback for months (#115 #67 #63).

@pitaj
Copy link

pitaj commented Feb 12, 2023

I realize the team is busy and stretched thin, but the stats do not look good. ACPs are sitting without activity for many months, even after they enter Initial Comment Period.

@eholk
Copy link

eholk commented May 3, 2023

Adding a note about what to do if it's taking longer than expected, like who to ping or a Zulip channel to open a thread on, would help a lot too.

I opened #90 back in August and the only comments I've heard have been from other people who would be interested in a similar feature. It's left me wondering whether I missed a step in the process beyond posting the issue. (And probably I should have followed up before 9 months later...)

@thomcc
Copy link
Member

thomcc commented May 3, 2023

I wonder if given the situation it's worth re-evaluating the ACP process, and adjusting or removing it. I feel like the status quo might be worse than what we had before...

@pitaj
Copy link

pitaj commented May 3, 2023

Yeah I can personally say it's very disheartening to create an ACP and get zero feedback, even after many months 😞

@BurntSushi
Copy link
Member

Okay, I merged #219 to at least update the text to give a more accurate expectation.

I do somewhat feel like promising a two week response time is a bit of a high bar to meet.

Another thing to consider is that we, as a team, are overall pretty conservative with what we let into std. Primarily because its support window is "approximately forever." So we should in general expect this sort of process to go somewhat slowly. Whether that also means we have to also respond to literally every incoming request within a short time window is perhaps a different problem though.

@ChrisDenton
Copy link
Member

I think it would be nice for a welcoming committee (not necessarily libs-api themselves) to give a non-official thanks and perhaps suggestions (e.g. if the proposal needs more motivation or its explanation is lacking in some way) within a few weeks if possible? Both to reassure the contributor they've been heard and to reduce the time libs-api ultimately need to spend on ACPs.

Some kind of triage would probably be good here too.

@pitaj
Copy link

pitaj commented May 5, 2023

Can we nominate this for discussion in the next libs-api meeting?

@Amanieu
Copy link
Member

Amanieu commented May 5, 2023

We will be having an in-person library team meetup in a week, and this is one of the topics that we will want to spend a significant amount of time on.

@pitaj
Copy link

pitaj commented May 19, 2023

New process is proposed here

rust-lang/std-dev-guide#55

@dtolnay dtolnay added the documentation Improvements or additions to documentation label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

8 participants