Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SinkExt::send_all should work with TryStream? #1817

Closed
tedsta opened this issue Aug 20, 2019 · 1 comment · Fixed by #1946
Closed

SinkExt::send_all should work with TryStream? #1817

tedsta opened this issue Aug 20, 2019 · 1 comment · Fixed by #1946
Milestone
0.3 release

Comments

@tedsta
Copy link

tedsta commented Aug 20, 2019

I have a Sink<MyMsg, Error=MyError> and I'd like to send_all it a stream, Stream<Item=Result<MyMsg, MyError>>.

StreamExt::forward almost works for me, but I need to keep using the Sink after.

Perhaps a SinkExt::try_send_all with where St: TryStream<Ok = Item, Error = Error>? I can send a PR if you guys are open to it.
@cramertj cramertj added this to the 0.3 release milestone Oct 30, 2019
@cramertj
Copy link
Member

Agreed-- TryStream seems sensible to support here.

@cramertj cramertj mentioned this issue Nov 5, 2019
Merged
@benesch benesch mentioned this issue Jan 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3 release
Development

Successfully merging a pull request may close this issue.

Use TryStream in Sink::send_all cramertj/futures-rs
2 participants
@tedsta @cramertj