Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: set_dictionary in pure Rust backend #358

Closed
torokati44 opened this issue Jul 2, 2023 · 2 comments
Closed

Feature request: set_dictionary in pure Rust backend #358

torokati44 opened this issue Jul 2, 2023 · 2 comments

Comments

@torokati44
Copy link

I'd like to use the mentioned functionality in a project that is built to WASM, so only using native Rust stuff is preferred.

Based on #74 (comment), adding this "should be relatively simple".

@torokati44
Copy link
Author

Actually, for this purpose, if any of the available zlib backends supports seamless compiling to WASM from source, that would also work... 😶

@Byron Byron changed the title Feature request: set_dictionary without zlib Feature request: set_dictionary in pure Rust backend Jul 3, 2023
@Byron
Copy link
Member

Byron commented Jul 3, 2023

Thanks for posting. After taking a closer look, I believe this feature request should first be posted over at the miniz_oxide which is the implementation used here when the Rust backend is chosen.

Once available, it should be trivial to make set_dictionary available here.

WASM support is available in this crate as well, even though it does seem to default to miniz_oxide when that happens. Thus the way forward truly seems to be to get the desired feature implemented in miniz_oxide.

For that reason, I am closing the issue here as I trust you will open a new one once the pre-requisites are fulfilled. Thanks for your understanding.

@Byron Byron closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2023
@Byron Byron removed the help wanted label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants