Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source viewer sometimes links to empty_library in file tree #1453

Closed
cdmistman opened this issue Jul 21, 2021 · 5 comments
Closed

Source viewer sometimes links to empty_library in file tree #1453

cdmistman opened this issue Jul 21, 2021 · 5 comments

Comments

@cdmistman
Copy link

cdmistman commented Jul 21, 2021

In some crates, the file tree simply links to some empty crate called empty_library which contains a single file, lib.rs. Clicking on the file results in a 404

Most recent example I've found is in the source viewer for HashBrown (linking to map.rs, although accessing any source file through https://docs.rs/hashbrown/0.11.2 results in the bad source tree. This has happened for multiple crates (and I can add more links as I find them) but notably might only affect certain versions - for example, the source file tree works when looking at https://docs.rs/hashbrown/0.11.1

If this is a rustdoc issue and not docs.rs then I can close this issue and reopen in rust-lang/rust

@syphar
Copy link
Member

syphar commented Jul 21, 2021

Thank you for the report!
This specific source-viewer and it's file-list are build in docs.rs, so it's definitely an issue with us here.

That being said, I just ran a clean build of this crate and version locally and the file-list is correct.

So it seems like a past bug / production issue that could be solved by a rebuild. If it isn't a known issue we could query other releases that share the file-list with empty-library, but aren't it. Though it would be tricky to differentiate between these and other empty libraries.

@cdmistman
Copy link
Author

Awesome, glad it can be resolved easily! I do remember this impacting other crates, although I can't remember any others so I can't give you any more that suffer from the bug. It's still appearing as empty_library for me, I'm assuming it'll take a while to update?

@Nemo157
Copy link
Member

Nemo157 commented Jul 21, 2021

This specific source-viewer and it's file-list are build in docs.rs, so it's definitely an issue with us here.

This is the one generated by rustdoc, the docs.rs one looks fine for this release.

@jyn514
Copy link
Member

jyn514 commented Jul 21, 2021

Duplicate of #1313

@jyn514 jyn514 marked this as a duplicate of #1313 Jul 21, 2021
@jyn514 jyn514 closed this as completed Jul 21, 2021
@syphar
Copy link
Member

syphar commented Jul 22, 2021

damn, confused the two viewers again 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants