Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new favicon sizes not added as hashed essential files. #1240

Closed
syphar opened this issue Jan 5, 2021 · 2 comments · Fixed by #1312
Closed

new favicon sizes not added as hashed essential files. #1240

syphar opened this issue Jan 5, 2021 · 2 comments · Fixed by #1312

Comments

@syphar
Copy link
Member

syphar commented Jan 5, 2021

I'm seeing these 404 errors:
image

when accessing for example the itertools docs.

I guess it's related to ESSENTIAL_FILES_VERSIONED and add-essential-files, but I couldn't make it work quickly and don't know the build-process good enough yet.

@syphar
Copy link
Member Author

syphar commented Jan 5, 2021

I created this issue so I don't forget it, and perhaps someone else with more knowledge of the build will give a hint or do it.

Otherwise I'll be coming back to this at some point

@jyn514
Copy link
Member

jyn514 commented Mar 18, 2021

@syphar I think you would add it to ESSENTIAL_FILES_VERSIONED, the same as other versioned files: #1301. You may want to wait for the discussion in #1312 to die down, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants