Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are files like absvdi2.c or absvsi2.c still compiled? #240

Open
est31 opened this issue Apr 15, 2018 · 2 comments
Open

Why are files like absvdi2.c or absvsi2.c still compiled? #240

est31 opened this issue Apr 15, 2018 · 2 comments

Comments

@est31
Copy link
Member

est31 commented Apr 15, 2018

According to the README, they are never called by LLVM and thus don't have to be implemented in Rust. But why is their C implementation being compiled?

@Amanieu
Copy link
Member

Amanieu commented Apr 15, 2018

While they are not called by LLVM, there are some builtins that are called by GCC-generated code. I haven't checked if this applies to these particular functions though.

IIRC this is mainly relevant when we are statically linking to GCC-generated C code, such as musl targets. I don't think we are linking to libgcc on those targets (maybe we should?).

@est31
Copy link
Member Author

est31 commented Apr 15, 2018

hmmm so this sort of gets into the terrirory of #217 ? Either way, I think we should either reimplement those files in Rust, or remove them. But keeping them around and requiring people to have a C compiler for that platform around is not nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants