Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute flags only when interning #666

Closed
jackh726 opened this issue Dec 11, 2020 · 0 comments · Fixed by #682
Closed

Compute flags only when interning #666

jackh726 opened this issue Dec 11, 2020 · 0 comments · Fixed by #682
Labels
C-chalk-ir Issues related to the chalk-ir crate

Comments

@jackh726
Copy link
Member

This is probably a large enough change to be in another PR, but I would expect the interner to compute the flags, so that in the case it is actually interning it only has to compute flags when it's allocating.

Originally posted by @matthewjasper in #639 (comment)
@jackh726 jackh726 added the C-chalk-ir Issues related to the chalk-ir crate label Dec 11, 2020
@detrumi detrumi mentioned this issue Feb 2, 2021
Merged
@bors bors closed this as completed in 3e0dbd8 Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-chalk-ir Issues related to the chalk-ir crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compute flags in interner detrumi/chalk
1 participant
@jackh726