Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent documentation for build parallelism #826

Closed
NobodyXu opened this issue Jul 20, 2023 · 2 comments · Fixed by #827
Closed

Inconsistent documentation for build parallelism #826

NobodyXu opened this issue Jul 20, 2023 · 2 comments · Fixed by #827

Comments

@NobodyXu
Copy link
Collaborator

The crate-level doc says that:

If NUM_JOBS is not set, the RAYON_NUM_THREADS environment variable can
also specify the build parallelism.

However in default_jobserver(), only NUM_JOBS is used but not RAYON_NUM_THREADS.

It seems like this is an outdated documentation, but I'm not entirely sure so I opened this issue.
@thomcc
Copy link
Member

thomcc commented Jul 20, 2023

Yeah, a long time ago we used rayon. This documentation is outdated though.

@NobodyXu
Copy link
Collaborator Author

I will open a PR to remove this.

@NobodyXu NobodyXu mentioned this issue Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove outdated doc about build parallelism
2 participants
@thomcc @NobodyXu