Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLL Suffix Panic #8308

Closed
not-matthias opened this issue Jun 2, 2020 · 0 comments · Fixed by #8310
Closed

DLL Suffix Panic #8308

not-matthias opened this issue Jun 2, 2020 · 0 comments · Fixed by #8310
Labels
C-bug Category: bug

Comments

@not-matthias
Copy link

Problem

When changing the dll suffix an assertion will be triggered. I'm using cargo-xbuild to build a custom target and there I can add an option to change the suffix.

Steps

I created a repository with an example and the steps how to reproduce it: https://github.com/not-matthias/rust-dll-extension

Possible Solution(s)
Only the dll suffix has been changed and the dll is still the same. Thus it should be possible to just remove the assertion.

Here's the affected code:

And here's the pull request that introduced this behaviour: #8210

Notes

OS: Windows 10

Output of cargo version:

cargo 1.45.0-nightly (9fcb8c1d2 2020-05-25)

Output of rustup show:

nightly-x86_64-pc-windows-msvc (default)
rustc 1.45.0-nightly (ad4bc3323 2020-06-01)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant