Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace silently ignores parts of the version #7434

Closed
nrc opened this issue Sep 26, 2019 · 2 comments
Closed

replace silently ignores parts of the version #7434

nrc opened this issue Sep 26, 2019 · 2 comments
Labels
A-replace Area: [replace] table override C-bug Category: bug

Comments

@nrc
Copy link
Member

nrc commented Sep 26, 2019

If you try and replace a crate with a version more complex than x.y.z, the parts of the version other than x.y.z are ignored, which usually means the replace does not match any crates and has no effect (Cargo warns about this).

E.g., grpcio:0.5.0-alpha.3 will not match deps with version = "0.5.0-alpha.3"

@nrc nrc added the C-bug Category: bug label Sep 26, 2019
@ehuss ehuss added the A-replace Area: [replace] table override label Sep 26, 2019
@ehuss
Copy link
Contributor

ehuss commented Sep 26, 2019

Considering replace is mostly deprecated, I imagine it may be unlikely that effort will go into fixing this. There are also several known issues with how pre-release versions are handled, which may be the root of this problem.

Can [patch] work for you instead?

@epage
Copy link
Contributor

epage commented Oct 31, 2023

As replace is deprecated and without further information in several years on if patch would instead work, I'm going to go ahead and close this. If there is a reason to keep this open, let us know!

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-replace Area: [replace] table override C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

3 participants