cargo fix fails to apply -Wsingle-use-lifetimes on crater

[matthiaskrgr]

git clone https://github.com/rust-lang-nursery/crater
cd crater
git checkout 9dbf4002e6b4d0be2848cd72a85657f2aee4b92f
RUSTFLAGS="-Welided-lifetimes-in-paths"  cargo fix

   Compiling crater v0.1.0 (/home/matthias/vcs/github/crater)
warning: failed to automatically apply fixes suggested by rustc to crate `crater`

after fixes were automatically applied the compiler reported errors within these files:

  * src/utils/macros.rs

This likely indicates a bug in either rustc or cargo itself,
and we would appreciate a bug report! You're likely to see
a number of compiler warnings after this message which cargo
attempted to fix but failed. If you could open an issue at
https://github.com/rust-lang/cargo/issues
quoting the full output of this command we'd be very appreciative!

warning: hidden lifetime parameters in types are deprecated
  --> src/assets.rs:93:32
   |
93 |     fn load(&self) -> Fallible<Cow<[u8]>> {
   |                                ^^^^^^^^^ help: indicate the anonymous lifetime: `Cow<'_, [u8]>`

warning: hidden lifetime parameters in types are deprecated
   --> src/assets.rs:111:39
    |
111 |     pub fn content(&self) -> Fallible<Cow<[u8]>> {
    |                                       ^^^^^^^^^ help: indicate the anonymous lifetime: `Cow<'_, [u8]>`

warning: hidden lifetime parameters in types are deprecated
  --> src/logs/storage.rs:43:34
   |
43 |     fn enabled(&self, metadata: &Metadata) -> bool {
   |                                  ^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/logs/storage.rs:47:28
   |
47 |     fn log(&self, record: &Record) {
   |                            ^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/logs/storage.rs:62:27
   |
62 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/logs/mod.rs:40:34
   |
40 |     fn enabled(&self, metadata: &Metadata) -> bool {
   |                                  ^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/logs/mod.rs:50:28
   |
50 |     fn log(&self, record: &Record) {
   |                            ^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/size.rs:15:27
   |
15 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:51:45
   |
51 |                 fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                             ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/utils/size.rs:52:1
   |
52 | impl_serde_from_parse!(Size, expecting = "a size");
   | --------------------------------------------------- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/crates/mod.rs:67:27
   |
67 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/db/migrations.rs:13:18
   |
13 |     Code(Box<Fn(&Transaction) -> ::rusqlite::Result<()>>),
   |                  ^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/db/mod.rs:80:38
   |
80 |     pub fn transaction<T, F: FnOnce(&TransactionHandle) -> Fallible<T>>(
   |                                      ^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/db/mod.rs:140:29
    |
140 |     fn get_row<T, F: FnMut(&Row) -> T>(
    |                             ^^^- help: indicate the anonymous lifetimes: `<'_, '_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/db/mod.rs:160:27
    |
160 |     fn query<T, F: FnMut(&Row) -> T>(
    |                           ^^^- help: indicate the anonymous lifetimes: `<'_, '_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/docker.rs:235:27
    |
235 |     fn fmt(&self, f: &mut Formatter) -> fmt::Result {
    |                           ^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:20:35
   |
20 |               fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                     ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:11:1
   |
11 | / string_enum!(pub enum Status {
12 | |     Queued => "queued",
13 | |     Running => "running",
14 | |     NeedsReport => "needs-report",
...  |
17 | |     Completed => "completed",
18 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:51:45
   |
51 |                   fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                               ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:11:1
   |
11 | / string_enum!(pub enum Status {
12 | |     Queued => "queued",
13 | |     Running => "running",
14 | |     NeedsReport => "needs-report",
...  |
17 | |     Completed => "completed",
18 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:20:35
   |
20 |               fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                     ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:20:1
   |
20 | / string_enum!(pub enum Mode {
21 | |     BuildAndTest => "build-and-test",
22 | |     BuildOnly => "build-only",
23 | |     CheckOnly => "check-only",
24 | |     Rustdoc => "rustdoc",
25 | |     UnstableFeatures => "unstable-features",
26 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:51:45
   |
51 |                   fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                               ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:20:1
   |
20 | / string_enum!(pub enum Mode {
21 | |     BuildAndTest => "build-and-test",
22 | |     BuildOnly => "build-only",
23 | |     CheckOnly => "check-only",
24 | |     Rustdoc => "rustdoc",
25 | |     UnstableFeatures => "unstable-features",
26 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:20:35
   |
20 |               fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                     ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:28:1
   |
28 | / string_enum!(pub enum CrateSelect {
29 | |     Full => "full",
30 | |     Demo => "demo",
31 | |     SmallRandom => "small-random",
32 | |     Top100 => "top-100",
33 | |     Local => "local",
34 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:51:45
   |
51 |                   fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                               ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:28:1
   |
28 | / string_enum!(pub enum CrateSelect {
29 | |     Full => "full",
30 | |     Demo => "demo",
31 | |     SmallRandom => "small-random",
32 | |     Top100 => "top-100",
33 | |     Local => "local",
34 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:20:35
   |
20 |               fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                     ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:36:1
   |
36 | / string_enum!(pub enum CapLints {
37 | |     Allow => "allow",
38 | |     Warn => "warn",
39 | |     Deny => "deny",
40 | |     Forbid => "forbid",
41 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:51:45
   |
51 |                   fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                               ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:36:1
   |
36 | / string_enum!(pub enum CapLints {
37 | |     Allow => "allow",
38 | |     Warn => "warn",
39 | |     Deny => "deny",
40 | |     Forbid => "forbid",
41 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/experiments.rs:51:27
   |
51 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/experiments.rs:335:23
    |
335 |     fn from_row(row: &Row) -> Self {
    |                       ^^^- help: indicate the anonymous lifetimes: `<'_, '_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/report/s3.rs:136:56
    |
136 |     fn write_string<P: AsRef<Path>>(&self, path: P, s: Cow<str>, mime: &Mime) -> Fallible<()> {
    |                                                        ^^^^^^^^ help: indicate the anonymous lifetime: `Cow<'_, str>`

warning: hidden lifetime parameters in types are deprecated
   --> src/report/s3.rs:148:27
    |
148 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/report/s3.rs:154:27
    |
154 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:20:35
   |
20 |               fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                     ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/report/mod.rs:49:1
   |
49 | / string_enum!(pub enum Comparison {
50 | |     Regressed => "regressed",
51 | |     Fixed => "fixed",
52 | |     Skipped => "skipped",
...  |
60 | |     SpuriousFixed => "spurious-fixed",
61 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:51:45
   |
51 |                   fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                               ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/report/mod.rs:49:1
   |
49 | / string_enum!(pub enum Comparison {
50 | |     Regressed => "regressed",
51 | |     Fixed => "fixed",
52 | |     Skipped => "skipped",
...  |
60 | |     SpuriousFixed => "spurious-fixed",
61 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
   --> src/report/mod.rs:342:56
    |
342 |     fn write_string<P: AsRef<Path>>(&self, path: P, s: Cow<str>, mime: &Mime) -> Fallible<()>;
    |                                                        ^^^^^^^^ help: indicate the anonymous lifetime: `Cow<'_, str>`

warning: hidden lifetime parameters in types are deprecated
   --> src/report/mod.rs:368:56
    |
368 |     fn write_string<P: AsRef<Path>>(&self, path: P, s: Cow<str>, _: &Mime) -> Fallible<()> {
    |                                                        ^^^^^^^^ help: indicate the anonymous lifetime: `Cow<'_, str>`

warning: hidden lifetime parameters in types are deprecated
   --> src/report/mod.rs:382:27
    |
382 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/utils/macros.rs:20:35
    |
20  |               fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
    |                                     ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
    |
   ::: src/results/mod.rs:113:1
    |
113 | / string_enum!(pub enum FailureReason {
114 | |     Unknown => "unknown",
115 | |     Broken => "broken",
116 | |     OOM => "oom",
117 | |     Timeout => "timeout",
118 | | });
    | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
   --> src/utils/macros.rs:51:45
    |
51  |                   fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
    |                                               ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
    |
   ::: src/results/mod.rs:113:1
    |
113 | / string_enum!(pub enum FailureReason {
114 | |     Unknown => "unknown",
115 | |     Broken => "broken",
116 | |     OOM => "oom",
117 | |     Timeout => "timeout",
118 | | });
    | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
   --> src/results/mod.rs:93:35
    |
93  |               fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                                     ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
...
129 | / test_result_enum!(pub enum TestResult {
130 | |     with_reason {
131 | |         BuildFail(FailureReason) => "build-fail",
132 | |         TestFail(FailureReason) => "test-fail",
...   |
138 | |     }
139 | | });
    | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
   --> src/utils/macros.rs:51:45
    |
51  |                 fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
    |                                             ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
    |
   ::: src/results/mod.rs:141:1
    |
141 | impl_serde_from_parse!(TestResult, expecting = "a test result");
    | ---------------------------------------------------------------- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
   --> src/run.rs:126:62
    |
126 |     pub(crate) fn sandboxed(self, docker_env: &DockerEnv) -> SandboxedCommand {
    |                                                              ^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/graph.rs:39:27
   |
39 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/graph.rs:218:49
    |
218 |     pub(super) fn generate_dot<'a>(&'a self) -> Dot<&'a StableDiGraph<impl Debug, ()>> {
    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `Dot<'_, &'a StableDiGraph<impl Debug, ()>>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/tasks.rs:63:27
   |
63 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/tasks.rs:105:27
    |
105 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/test.rs:25:11
   |
25 |     ctx: &TaskCtx<DB>,
   |           ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/test.rs:63:11
   |
63 |     ctx: &TaskCtx<DB>,
   |           ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/test.rs:64:18
   |
64 |     test_fn: fn(&TaskCtx<DB>, &Path) -> Fallible<TestResult>,
   |                  ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/test.rs:99:34
   |
99 | fn build<DB: WriteResults>(ctx: &TaskCtx<DB>, source_path: &Path) -> Fallible<()> {
   |                                  ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/test.rs:105:33
    |
105 | fn test<DB: WriteResults>(ctx: &TaskCtx<DB>, source_path: &Path) -> Fallible<()> {
    |                                 ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/test.rs:110:11
    |
110 |     ctx: &TaskCtx<DB>,
    |           ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/test.rs:129:11
    |
129 |     ctx: &TaskCtx<DB>,
    |           ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/test.rs:140:11
    |
140 |     ctx: &TaskCtx<DB>,
    |           ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/test.rs:155:11
    |
155 |     ctx: &TaskCtx<DB>,
    |           ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/unstable_features.rs:10:12
   |
10 |     _ctx: &TaskCtx<DB>,
   |            ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/mod.rs:44:23
   |
44 |     fn lock(&self) -> std::sync::MutexGuard<RunnerStateInner> {
   |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `std::sync::MutexGuard<'_, RunnerStateInner>`

warning: hidden lifetime parameters in types are deprecated
  --> src/server/api_types.rs:71:27
   |
71 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/server/reports.rs:17:60
   |
17 | fn generate_report(data: &Data, ex: &Experiment, results: &DatabaseDB) -> Fallible<TestResults> {
   |                                                            ^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/toolchain.rs:106:27
    |
106 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/tools/mod.rs:14:26
   |
14 | pub(crate) static CARGO: Cargo = Cargo {
   |                          ^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/assets.rs:93:32
   |
93 |     fn load(&self) -> Fallible<Cow<[u8]>> {
   |                                ^^^^^^^^^ help: indicate the anonymous lifetime: `Cow<'_, [u8]>`

warning: hidden lifetime parameters in types are deprecated
   --> src/assets.rs:111:39
    |
111 |     pub fn content(&self) -> Fallible<Cow<[u8]>> {
    |                                       ^^^^^^^^^ help: indicate the anonymous lifetime: `Cow<'_, [u8]>`

warning: hidden lifetime parameters in types are deprecated
  --> src/logs/storage.rs:43:34
   |
43 |     fn enabled(&self, metadata: &Metadata) -> bool {
   |                                  ^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/logs/storage.rs:47:28
   |
47 |     fn log(&self, record: &Record) {
   |                            ^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/logs/storage.rs:62:27
   |
62 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/logs/mod.rs:40:34
   |
40 |     fn enabled(&self, metadata: &Metadata) -> bool {
   |                                  ^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/logs/mod.rs:50:28
   |
50 |     fn log(&self, record: &Record) {
   |                            ^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/size.rs:15:27
   |
15 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:51:45
   |
51 |                 fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                             ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/utils/size.rs:52:1
   |
52 | impl_serde_from_parse!(Size, expecting = "a size");
   | --------------------------------------------------- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/crates/mod.rs:67:27
   |
67 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/db/migrations.rs:13:18
   |
13 |     Code(Box<Fn(&Transaction) -> ::rusqlite::Result<()>>),
   |                  ^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/db/mod.rs:80:38
   |
80 |     pub fn transaction<T, F: FnOnce(&TransactionHandle) -> Fallible<T>>(
   |                                      ^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/db/mod.rs:140:29
    |
140 |     fn get_row<T, F: FnMut(&Row) -> T>(
    |                             ^^^- help: indicate the anonymous lifetimes: `<'_, '_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/db/mod.rs:160:27
    |
160 |     fn query<T, F: FnMut(&Row) -> T>(
    |                           ^^^- help: indicate the anonymous lifetimes: `<'_, '_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/docker.rs:235:27
    |
235 |     fn fmt(&self, f: &mut Formatter) -> fmt::Result {
    |                           ^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:20:35
   |
20 |               fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                     ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:11:1
   |
11 | / string_enum!(pub enum Status {
12 | |     Queued => "queued",
13 | |     Running => "running",
14 | |     NeedsReport => "needs-report",
...  |
17 | |     Completed => "completed",
18 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:51:45
   |
51 |                   fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                               ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:11:1
   |
11 | / string_enum!(pub enum Status {
12 | |     Queued => "queued",
13 | |     Running => "running",
14 | |     NeedsReport => "needs-report",
...  |
17 | |     Completed => "completed",
18 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:20:35
   |
20 |               fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                     ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:20:1
   |
20 | / string_enum!(pub enum Mode {
21 | |     BuildAndTest => "build-and-test",
22 | |     BuildOnly => "build-only",
23 | |     CheckOnly => "check-only",
24 | |     Rustdoc => "rustdoc",
25 | |     UnstableFeatures => "unstable-features",
26 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:51:45
   |
51 |                   fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                               ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:20:1
   |
20 | / string_enum!(pub enum Mode {
21 | |     BuildAndTest => "build-and-test",
22 | |     BuildOnly => "build-only",
23 | |     CheckOnly => "check-only",
24 | |     Rustdoc => "rustdoc",
25 | |     UnstableFeatures => "unstable-features",
26 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:20:35
   |
20 |               fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                     ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:28:1
   |
28 | / string_enum!(pub enum CrateSelect {
29 | |     Full => "full",
30 | |     Demo => "demo",
31 | |     SmallRandom => "small-random",
32 | |     Top100 => "top-100",
33 | |     Local => "local",
34 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:51:45
   |
51 |                   fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                               ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:28:1
   |
28 | / string_enum!(pub enum CrateSelect {
29 | |     Full => "full",
30 | |     Demo => "demo",
31 | |     SmallRandom => "small-random",
32 | |     Top100 => "top-100",
33 | |     Local => "local",
34 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:20:35
   |
20 |               fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                     ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:36:1
   |
36 | / string_enum!(pub enum CapLints {
37 | |     Allow => "allow",
38 | |     Warn => "warn",
39 | |     Deny => "deny",
40 | |     Forbid => "forbid",
41 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:51:45
   |
51 |                   fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                               ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/experiments.rs:36:1
   |
36 | / string_enum!(pub enum CapLints {
37 | |     Allow => "allow",
38 | |     Warn => "warn",
39 | |     Deny => "deny",
40 | |     Forbid => "forbid",
41 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/experiments.rs:51:27
   |
51 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/experiments.rs:335:23
    |
335 |     fn from_row(row: &Row) -> Self {
    |                       ^^^- help: indicate the anonymous lifetimes: `<'_, '_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/report/s3.rs:136:56
    |
136 |     fn write_string<P: AsRef<Path>>(&self, path: P, s: Cow<str>, mime: &Mime) -> Fallible<()> {
    |                                                        ^^^^^^^^ help: indicate the anonymous lifetime: `Cow<'_, str>`

warning: hidden lifetime parameters in types are deprecated
   --> src/report/s3.rs:148:27
    |
148 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/report/s3.rs:154:27
    |
154 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:20:35
   |
20 |               fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                     ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/report/mod.rs:49:1
   |
49 | / string_enum!(pub enum Comparison {
50 | |     Regressed => "regressed",
51 | |     Fixed => "fixed",
52 | |     Skipped => "skipped",
...  |
60 | |     SpuriousFixed => "spurious-fixed",
61 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
  --> src/utils/macros.rs:51:45
   |
51 |                   fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
   |                                               ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
  ::: src/report/mod.rs:49:1
   |
49 | / string_enum!(pub enum Comparison {
50 | |     Regressed => "regressed",
51 | |     Fixed => "fixed",
52 | |     Skipped => "skipped",
...  |
60 | |     SpuriousFixed => "spurious-fixed",
61 | | });
   | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
   --> src/report/mod.rs:342:56
    |
342 |     fn write_string<P: AsRef<Path>>(&self, path: P, s: Cow<str>, mime: &Mime) -> Fallible<()>;
    |                                                        ^^^^^^^^ help: indicate the anonymous lifetime: `Cow<'_, str>`

warning: hidden lifetime parameters in types are deprecated
   --> src/report/mod.rs:368:56
    |
368 |     fn write_string<P: AsRef<Path>>(&self, path: P, s: Cow<str>, _: &Mime) -> Fallible<()> {
    |                                                        ^^^^^^^^ help: indicate the anonymous lifetime: `Cow<'_, str>`

warning: hidden lifetime parameters in types are deprecated
   --> src/report/mod.rs:382:27
    |
382 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/report/mod.rs:413:56
    |
413 |     fn write_string<P: AsRef<Path>>(&self, path: P, s: Cow<str>, mime: &Mime) -> Fallible<()> {
    |                                                        ^^^^^^^^ help: indicate the anonymous lifetime: `Cow<'_, str>`

warning: hidden lifetime parameters in types are deprecated
   --> src/report/mod.rs:434:27
    |
434 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/utils/macros.rs:20:35
    |
20  |               fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
    |                                     ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
    |
   ::: src/results/mod.rs:113:1
    |
113 | / string_enum!(pub enum FailureReason {
114 | |     Unknown => "unknown",
115 | |     Broken => "broken",
116 | |     OOM => "oom",
117 | |     Timeout => "timeout",
118 | | });
    | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
   --> src/utils/macros.rs:51:45
    |
51  |                   fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
    |                                               ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
    |
   ::: src/results/mod.rs:113:1
    |
113 | / string_enum!(pub enum FailureReason {
114 | |     Unknown => "unknown",
115 | |     Broken => "broken",
116 | |     OOM => "oom",
117 | |     Timeout => "timeout",
118 | | });
    | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
   --> src/results/mod.rs:93:35
    |
93  |               fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                                     ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
...
129 | / test_result_enum!(pub enum TestResult {
130 | |     with_reason {
131 | |         BuildFail(FailureReason) => "build-fail",
132 | |         TestFail(FailureReason) => "test-fail",
...   |
138 | |     }
139 | | });
    | |___- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
   --> src/utils/macros.rs:51:45
    |
51  |                 fn expecting(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
    |                                             ^^^^^^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
    |
   ::: src/results/mod.rs:141:1
    |
141 | impl_serde_from_parse!(TestResult, expecting = "a test result");
    | ---------------------------------------------------------------- in this macro invocation

warning: hidden lifetime parameters in types are deprecated
   --> src/run.rs:126:62
    |
126 |     pub(crate) fn sandboxed(self, docker_env: &DockerEnv) -> SandboxedCommand {
    |                                                              ^^^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/graph.rs:39:27
   |
39 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/graph.rs:218:49
    |
218 |     pub(super) fn generate_dot<'a>(&'a self) -> Dot<&'a StableDiGraph<impl Debug, ()>> {
    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `Dot<'_, &'a StableDiGraph<impl Debug, ()>>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/tasks.rs:63:27
   |
63 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/tasks.rs:105:27
    |
105 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/test.rs:25:11
   |
25 |     ctx: &TaskCtx<DB>,
   |           ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/test.rs:63:11
   |
63 |     ctx: &TaskCtx<DB>,
   |           ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/test.rs:64:18
   |
64 |     test_fn: fn(&TaskCtx<DB>, &Path) -> Fallible<TestResult>,
   |                  ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/test.rs:99:34
   |
99 | fn build<DB: WriteResults>(ctx: &TaskCtx<DB>, source_path: &Path) -> Fallible<()> {
   |                                  ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/test.rs:105:33
    |
105 | fn test<DB: WriteResults>(ctx: &TaskCtx<DB>, source_path: &Path) -> Fallible<()> {
    |                                 ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/test.rs:110:11
    |
110 |     ctx: &TaskCtx<DB>,
    |           ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/test.rs:129:11
    |
129 |     ctx: &TaskCtx<DB>,
    |           ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/test.rs:140:11
    |
140 |     ctx: &TaskCtx<DB>,
    |           ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
   --> src/runner/test.rs:155:11
    |
155 |     ctx: &TaskCtx<DB>,
    |           ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/unstable_features.rs:10:12
   |
10 |     _ctx: &TaskCtx<DB>,
   |            ^^^^^^^^^^^ help: indicate the anonymous lifetime: `TaskCtx<'_, DB>`

warning: hidden lifetime parameters in types are deprecated
  --> src/runner/mod.rs:44:23
   |
44 |     fn lock(&self) -> std::sync::MutexGuard<RunnerStateInner> {
   |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `std::sync::MutexGuard<'_, RunnerStateInner>`

warning: hidden lifetime parameters in types are deprecated
  --> src/server/api_types.rs:71:27
   |
71 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
   |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/server/reports.rs:17:60
   |
17 | fn generate_report(data: &Data, ex: &Experiment, results: &DatabaseDB) -> Fallible<TestResults> {
   |                                                            ^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
   --> src/toolchain.rs:106:27
    |
106 |     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
    |                           ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`

warning: hidden lifetime parameters in types are deprecated
  --> src/tools/mod.rs:14:26
   |
14 | pub(crate) static CARGO: Cargo = Cargo {
   |                          ^^^^^- help: indicate the anonymous lifetime: `<'_>`

    Finished dev [unoptimized + debuginfo] target(s) in 16.04s

cargo 1.33.0-nightly (2cf1f5dda 2018-12-11)
release: 1.33.0
commit-hash: 2cf1f5dda2f7ed84e94c4d32f643e0f1f15352f0
commit-date: 2018-12-11

[ehuss]

I think this is a duplicate of rust-lang/rust#55768.

[alexcrichton]

Indeed!