Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning if the new crate would fail to be pushed to crates.io #2864

Closed
adelarsq opened this issue Jul 12, 2016 · 2 comments
Closed

Show a warning if the new crate would fail to be pushed to crates.io #2864

adelarsq opened this issue Jul 12, 2016 · 2 comments

Comments

@adelarsq
Copy link

When trying to use cargo new show a warning if the crate would fail to be pushed to crates.io.

This issue was based on this reddit topic.

@mattscamp
Copy link
Contributor

Skimmed through the comments and the code associated. It seems like the only difference between them is crates.io required ASCII characters and some reserved names we should be checking for. Is that accurate?

@alexcrichton
Copy link
Member

Thanks for the report! I think that this may actually be mostly a subset of #883, so I'm gonna close this in favor of that.

Yeah I think it'd be fine to change cargo new though to verify that the project name doesn't have ASCII by default, as that's mostly what crates.io does. I originally wanted to leave most of this validation to crates.io to avoid duplicating, but it should be small enough that it's harmless to duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants